From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJC0z-0006vs-VX for qemu-devel@nongnu.org; Tue, 23 Jun 2009 15:50:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJC0u-0006op-VF for qemu-devel@nongnu.org; Tue, 23 Jun 2009 15:50:45 -0400 Received: from [199.232.76.173] (port=53701 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJC0u-0006oa-P7 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 15:50:40 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37334) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJC0u-0007sV-7M for qemu-devel@nongnu.org; Tue, 23 Jun 2009 15:50:40 -0400 Message-ID: <4A413213.5050703@redhat.com> Date: Tue, 23 Jun 2009 22:50:43 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs References: <1245763236-23464-1-git-send-email-avi@redhat.com> <20090623165006.GC27211@lst.de> <4A41095D.7070608@redhat.com> <20090623182622.GA5804@lst.de> <4A411F9B.5020508@redhat.com> <20090623194114.GA11045@lst.de> In-Reply-To: <20090623194114.GA11045@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org On 06/23/2009 10:41 PM, Christoph Hellwig wrote: > On Tue, Jun 23, 2009 at 09:31:55PM +0300, Avi Kivity wrote: > >> I meant in an omg we have to look at all the consequences way rather >> than byte count. This patch is somewhat less local. >> > > My patch makes sure a re-used acb is in the same state as a newly > allocated one. I think that's much more sensible than messing around > with some state during freeing some acbs. > > What if it has pointers to allocated stuff it was planning to reuse? You're leaking memory. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.