From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJMkU-0006aU-DE
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 03:18:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJMkO-0006a6-Rv
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 03:18:25 -0400
Received: from [199.232.76.173] (port=43488 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJMkO-0006a3-Ml
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 03:18:20 -0400
Received: from mx20.gnu.org ([199.232.41.8]:55353)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jes@sgi.com>) id 1MJMkO-0007Qg-6z
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 03:18:20 -0400
Received: from relay2.sgi.com ([192.48.179.30] helo=relay.sgi.com)
	by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from <jes@sgi.com>)
	id 1MJMkN-0000Yl-BM
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 03:18:19 -0400
Message-ID: <4A41D2C2.6010100@sgi.com>
Date: Wed, 24 Jun 2009 09:16:18 +0200
From: Jes Sorensen <jes@sgi.com>
MIME-Version: 1.0
References: <20090623100009.827553739@sgi.com> <4A40BE90.4040709@redhat.com>
	<4A40D965.7010508@sgi.com> <4A40DA69.7010300@redhat.com>
	<4A40EF9D.90303@sgi.com> <4A40F91D.5060102@redhat.com>
In-Reply-To: <4A40F91D.5060102@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [patch 0/2] QEMU maxcpus support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 06/23/2009 05:47 PM, Avi Kivity wrote:
> On 06/23/2009 06:07 PM, Jes Sorensen wrote:
>> DEF("smp", HAS_ARG, QEMU_OPTION_smp,
>> - "-smp n set the number of CPUs to 'n' [default=1]\n")
>> + "-smp n,[maxcpus=cpus]\n"
>
> -smp n[,maxcpus=cpus]

I don't follow you there, please elaborate.

>> + if (*p++ != ',')
>> + break;
>
> Won't this misparse "-smp 17z"?

It will be parsed as -smp 17, which is consistent with how the rest of
the options are parsed in QEMU. I am not going to rewrite the whole
parser for you :)

Cheers,
Jes