From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJOPX-0003Xq-Cb for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:04:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJOPS-0003W6-Qa for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:04:54 -0400 Received: from [199.232.76.173] (port=50236 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJOPS-0003W3-NI for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:04:50 -0400 Received: from relay3.sgi.com ([192.48.156.57]:42583 helo=relay.sgi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJOPR-0001mc-MZ for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:04:50 -0400 Message-ID: <4A41EBB8.5000802@sgi.com> Date: Wed, 24 Jun 2009 11:02:48 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <20090624083512.766907560@sgi.com> <20090624083725.117898545@sgi.com> <4A41EBBD.3090707@redhat.com> In-Reply-To: <4A41EBBD.3090707@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [patch 1/2] Introduce -smp , maxcpus= flag to specify maximum number of CPUS. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , qemu-devel@nongnu.org On 06/24/2009 11:02 AM, Avi Kivity wrote: > On 06/24/2009 11:35 AM, Jes Sorensen wrote: >> Follow on patch will use it to determine the size of the MADT and >> other BIOS tables. >> >> +int max_cpus = 16; > > Again I should have noticed this before, but this and the other > constants should come from the QEMUMachine we're targeting, since each > target has different limits. Actually this is on purpose. The PC machine has a max limit of 255, if we use that as the max per default, you are going to get a BIOS declaring 255 possible CPUs and certain broken operating systems are not going to boot. So I will argue the code is correct as is. Cheers, Jes