From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJOXj-0007Jp-N3
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:13:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJOXe-0007Ee-QT
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:13:22 -0400
Received: from [199.232.76.173] (port=51594 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJOXe-0007EV-DB
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:13:18 -0400
Received: from mx2.redhat.com ([66.187.237.31]:57178)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MJOXd-0003T3-WD
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:13:18 -0400
Message-ID: <4A41EDE6.2030204@redhat.com>
Date: Wed, 24 Jun 2009 11:12:06 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] the qemu-iotests test suite is now available
References: <20090622210523.GA8024@lst.de> <4A40FCDB.6090204@codemonkey.ws>
	<20090623163637.GA27211@lst.de>
In-Reply-To: <20090623163637.GA27211@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Christoph Hellwig schrieb:
> On Tue, Jun 23, 2009 at 11:03:39AM -0500, Anthony Liguori wrote:
>> The only thing that would be nice to have is the ability to point it at 
>> a build directory.  Setting PATH isn't enough because it expects a qemu 
>> executable whereas my build directory has a qemu-system-x86_64 executable.
> 
> Now that you remember it I remember the qemu-system-x86_64 problem.  I
> think we can try the various qemu-system-$foo binaries instead.

And the qemu-system-x86_64 binary is even in a subdirectory whereas
qemu-img and qemu-io are in the parent directory. Which would require me
to add two directories to PATH.

>> Why does it need to run qemu?  Shouldn't qemu-io/qemu-img be enough?
> 
> Test 007 uses the savevm command in the qemu monitor.  I suspect we
> could appromiate it whith the snapshot commands in qemu-img, but
> touching existing testcases is pretty nasty.

It's not enough. qemu-img snapshot -c doesn't save a VM state which is
an important test case. It should be doing unusual things like writing
past the end of the virtual hard disk and possibly growing the L1 table
when doing so.

Kevin