From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJOZI-00084p-Eh
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:15:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJOZD-00082R-E4
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:14:59 -0400
Received: from [199.232.76.173] (port=51664 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJOZC-00082G-Vw
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:14:55 -0400
Received: from mx2.redhat.com ([66.187.237.31]:57210)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MJOZC-0003kN-Kg
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 05:14:54 -0400
Message-ID: <4A41EEC9.9060003@redhat.com>
Date: Wed, 24 Jun 2009 12:15:53 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20090624083512.766907560@sgi.com>
	<20090624083725.117898545@sgi.com>
	<4A41EBBD.3090707@redhat.com> <4A41EBB8.5000802@sgi.com>
In-Reply-To: <4A41EBB8.5000802@sgi.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [patch 1/2] Introduce -smp ,
 maxcpus= flag to specify maximum number of CPUS.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <jes@sgi.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 06/24/2009 12:02 PM, Jes Sorensen wrote:
> On 06/24/2009 11:02 AM, Avi Kivity wrote:
>> On 06/24/2009 11:35 AM, Jes Sorensen wrote:
>>> Follow on patch will use it to determine the size of the MADT and
>>> other BIOS tables.
>>>
>>> +int max_cpus = 16;
>>
>> Again I should have noticed this before, but this and the other
>> constants should come from the QEMUMachine we're targeting, since each
>> target has different limits.
>
> Actually this is on purpose. The PC machine has a max limit of 255, if
> we use that as the max per default, you are going to get a BIOS
> declaring 255 possible CPUs and certain broken operating systems are not
> going to boot.
>
> So I will argue the code is correct as is.
>

What about the various ARMs, powerpcs, and sparcs that we support?

-- 
error compiling committee.c: too many arguments to function