qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH 2/2] introduce -cpu host target
Date: Wed, 24 Jun 2009 13:04:22 +0200	[thread overview]
Message-ID: <4A420836.10302@amd.com> (raw)
In-Reply-To: <4A41F7EC.2000305@redhat.com>

Avi Kivity wrote:
> On 06/23/2009 12:47 AM, Andre Przywara wrote:
>> Should we ignore unhandled MSRs like QEMU or Xen do?
>>    
> 
> Ignoring unhandled msrs is dangerous.  If a write has some effect the 
> guest depends on, and we're not emulating that effect, the guest will 
> fail.  Similarly if you don't know what a register mean, who knows what 
> returning zero for a read will do.
I agree - from an academic POV.
But if the pragmatic approach simply enables many guests to run, then 
it's at least worth considering it.
And with the current approach the guest fails, too (due to the injected 
#GP).
If I only look at AMD's list of MSRs (not to speak of the internal list 
;-), there will be a lot of work to emulate them. Even worse, most of 
them cannot be properly emulated (like disable Lock prefix).

But nevertheless I would like to continue the "patch-on-demand" path by 
catching those MSRs that in-the-wild OSes really touch and handle them 
appropriately. Hopefully that will cover most of the MSRs.
Maybe we could consider an (module? QEMU cmdline?) option to ignore 
unknown MSRs.

Regards,
Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448 3567 12
----to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2009-06-24 11:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22 21:47 [Qemu-devel] [PATCH 2/2] introduce -cpu host target Andre Przywara
2009-06-23 10:04 ` [Qemu-devel] " Avi Kivity
2009-06-24  9:54 ` Avi Kivity
2009-06-24 11:04   ` Andre Przywara [this message]
2009-06-24 11:26     ` Avi Kivity
2009-06-24 16:43     ` Jamie Lokier
2009-06-24 17:37   ` Filip Navara
2009-06-24 17:46     ` Avi Kivity
2009-06-24 17:59       ` Filip Navara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A420836.10302@amd.com \
    --to=andre.przywara@amd.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).