From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJWY3-0003BX-1Y for qemu-devel@nongnu.org; Wed, 24 Jun 2009 13:46:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJWXy-00035e-Bh for qemu-devel@nongnu.org; Wed, 24 Jun 2009 13:46:14 -0400 Received: from [199.232.76.173] (port=46329 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJWXy-00035U-5O for qemu-devel@nongnu.org; Wed, 24 Jun 2009 13:46:10 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53607) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJWXx-0001ds-Hj for qemu-devel@nongnu.org; Wed, 24 Jun 2009 13:46:09 -0400 Message-ID: <4A426665.1030506@redhat.com> Date: Wed, 24 Jun 2009 20:46:13 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 2/2] introduce -cpu host target References: <1245707277-769-1-git-send-email-andre.przywara@amd.com> <4A41F7EC.2000305@redhat.com> <5b31733c0906241037t54706611w19eeb2f27f8e63f3@mail.gmail.com> In-Reply-To: <5b31733c0906241037t54706611w19eeb2f27f8e63f3@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: Andre Przywara , aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On 06/24/2009 08:37 PM, Filip Navara wrote: > On Wed, Jun 24, 2009 at 11:54 AM, Avi Kivity wrote: > >> On 06/23/2009 12:47 AM, Andre Przywara wrote: >> >>> Should we ignore unhandled MSRs like QEMU or Xen do? >>> >>> >> Ignoring unhandled msrs is dangerous. If a write has some effect the guest >> depends on, and we're not emulating that effect, the guest will fail. >> Similarly if you don't know what a register mean, who knows what returning >> zero for a read will do. >> > > It is definitely a bad idea to ignore unknown MSRs. Kernel patch > protection scheme used by certain operating system depend on them to > work properly and it's pretty hard to debug when you don't know what > failed (the MSR read in this case). > > http://www.uninformed.org/?v=3&a=3 > http://www.uninformed.org/?v=6&a=1 > http://www.uninformed.org/?v=8&a=5 > http://en.wikipedia.org/wiki/Kernel_Patch_Protection > > Which unknown msrs are used by kernel patch protection? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.