From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJjBm-00053L-7q
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 03:16:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJjBh-0004qL-JZ
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 03:16:05 -0400
Received: from [199.232.76.173] (port=52553 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJjBh-0004ps-F4
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 03:16:01 -0400
Received: from mx20.gnu.org ([199.232.41.8]:54283)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jan.kiszka@web.de>) id 1MJjBg-0004zD-T8
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 03:16:01 -0400
Received: from fmmailgate02.web.de ([217.72.192.227])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MJjBg-000687-3P
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 03:16:00 -0400
Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166])
	by fmmailgate02.web.de (Postfix) with ESMTP id 45305104FADB2
	for <qemu-devel@nongnu.org>; Thu, 25 Jun 2009 09:15:59 +0200 (CEST)
Received: from [88.65.45.1] (helo=[192.168.1.10])
	by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.110 #277) id 1MJjBe-0008Ku-00
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 09:15:58 +0200
Message-ID: <4A43242D.9090106@web.de>
Date: Thu, 25 Jun 2009 09:15:57 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4A431D3D.2040604@web.de>
In-Reply-To: <4A431D3D.2040604@web.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: drive_add vs. pci_add
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>

Jan Kiszka wrote:
> Hi,
> 
> sorry, it's still early, but isn't the monitor command 'drive_add'
> completely redundant to 'pci_add ... storage'? If yes, and drive_add is
> only there for legacy users, I would mask its help from the monitor
> interface to avoid confusion.

One coffee later, the picture is clear: drive_add adds a drive to an
existing controller (one should read the doc completely). 'pci_add ...
storage' adds a storage controller, but can also add a first drive to
that controller. The latter feature definitely requires a better
documentation than "Hot-add PCI device".

Jan