From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJr1U-0006Za-6H for qemu-devel@nongnu.org; Thu, 25 Jun 2009 11:38:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJr1P-0006Rg-Fg for qemu-devel@nongnu.org; Thu, 25 Jun 2009 11:37:59 -0400 Received: from [199.232.76.173] (port=57610 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJr1P-0006RR-BC for qemu-devel@nongnu.org; Thu, 25 Jun 2009 11:37:55 -0400 Received: from mx2.redhat.com ([66.187.237.31]:56994) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJr1O-00025W-RO for qemu-devel@nongnu.org; Thu, 25 Jun 2009 11:37:55 -0400 Message-ID: <4A439A15.5040707@redhat.com> Date: Thu, 25 Jun 2009 18:39:01 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] drive_add vs. pci_add References: <4A431D3D.2040604@web.de> In-Reply-To: <4A431D3D.2040604@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On 06/25/2009 09:46 AM, Jan Kiszka wrote: > Hi, > > sorry, it's still early, but isn't the monitor command 'drive_add' > completely redundant to 'pci_add ... storage'? If yes, and drive_add is > only there for legacy users, I would mask its help from the monitor > interface to avoid confusion. > What we really want is pci_add storage to add a storage controller, and drive_add to attach a drive to that controller. I don't think that's what happens now. -- error compiling committee.c: too many arguments to function