From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJrUF-0003ss-31
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 12:07:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJrUA-0003qs-Cj
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 12:07:42 -0400
Received: from [199.232.76.173] (port=37297 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJrUA-0003qj-8E
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 12:07:38 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:60625)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MJrU9-0006xx-5R
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 12:07:37 -0400
Message-ID: <4A43A0BB.7010404@web.de>
Date: Thu, 25 Jun 2009 18:07:23 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] drive_add vs. pci_add
References: <4A431D3D.2040604@web.de> <4A439A15.5040707@redhat.com>
In-Reply-To: <4A439A15.5040707@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig812C9D26F6E8B19A5D7567AA"
Sender: jan.kiszka@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig812C9D26F6E8B19A5D7567AA
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Avi Kivity wrote:
> On 06/25/2009 09:46 AM, Jan Kiszka wrote:
>> Hi,
>>
>> sorry, it's still early, but isn't the monitor command 'drive_add'
>> completely redundant to 'pci_add ... storage'? If yes, and drive_add i=
s
>> only there for legacy users, I would mask its help from the monitor
>> interface to avoid confusion.
>>   =20
>=20
> What we really want is pci_add storage to add a storage controller, and=

> drive_add to attach a drive to that controller.  I don't think that's
> what happens now.
>=20

The latter should already happen, but we probably need to drop that
"first drive included" from the former. Also, there is no drive_remove.

I'm going to did into the whole hotplug user interface later, it has
some room for improvements.

Jan


--------------enig812C9D26F6E8B19A5D7567AA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkpDoMEACgkQniDOoMHTA+mIMgCfUaRBQjKXYjdBV10XVUJZf9cI
6a8AnRuf75fRR5wag/6ZYZYwROaIZ7qf
=SHHH
-----END PGP SIGNATURE-----

--------------enig812C9D26F6E8B19A5D7567AA--