From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MK7Iv-00019B-SP for qemu-devel@nongnu.org; Fri, 26 Jun 2009 05:01:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MK7Ip-00013P-To for qemu-devel@nongnu.org; Fri, 26 Jun 2009 05:01:04 -0400 Received: from [199.232.76.173] (port=42946 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MK7Ip-000135-PN for qemu-devel@nongnu.org; Fri, 26 Jun 2009 05:00:59 -0400 Received: from mx2.redhat.com ([66.187.237.31]:56402) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MK7Ip-0008Jz-6Y for qemu-devel@nongnu.org; Fri, 26 Jun 2009 05:00:59 -0400 Message-ID: <4A448E46.1000707@redhat.com> Date: Fri, 26 Jun 2009 12:00:54 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/11] QMP: Introduce specification file References: <4A4252DD.70300@redhat.com> <20090624190539.GR14121@shareable.org> <5b31733c0906241224j50baa7e6lc80b8c79c5d6baa7@mail.gmail.com> <20090624211358.GA14121@shareable.org> <4A43768A.2090604@eu.citrix.com> <4A438FDD.5060206@redhat.com> <4A43935D.6000506@codemonkey.ws> <4A4395B8.4010401@redhat.com> <4A43AE13.4030900@eu.citrix.com> <4A43BD9C.8070304@codemonkey.ws> <20090625190302.GA11937@redhat.com> In-Reply-To: <20090625190302.GA11937@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: "ehabkost@redhat.com" , Stefano Stabellini , "jan.kiszka@siemens.com" , "dlaor@redhat.com" , "qemu-devel@nongnu.org" , Luiz Capitulino , Filip Navara , Vincent Hanquez On 06/25/2009 10:03 PM, Daniel P. Berrange wrote: > On Thu, Jun 25, 2009 at 01:10:36PM -0500, Anthony Liguori wrote: > >> Stefano Stabellini wrote: >> >>> Clearly I agree with Avi. >>> I am thinking for example that we could use the RPC protocol directly >>> >> >from Xend and I am sure other people will find it useful too. >> >>> >>> >> But you can also use QMP from Xend. In fact, it should be pretty easy >> to convert the current code in Xend to use QMP. >> > > AFAIK, the current XenD code doesn't talk to the QEMU monitor at all, > instead having a add-on to QEMU code which pulls info from XenStored. > That doesn't alter your point though, it would be pretty easy to make > XenD talk to the proposed QMP monitor if desired. > All it takes is implementing QMP, and an emitter/parser for each qemu command. On the other hand, things like xml-rpc require around one line of code in Python per command. Let's turn this around. IIRC libvirt uses an RPC interface for its clients. How would you estimate the effort to port this interface to QMP, and adapt all its clients? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.