From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MKDri-0005iB-QF
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 12:01:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MKDre-0005hU-2B
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 12:01:26 -0400
Received: from [199.232.76.173] (port=40166 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MKDrd-0005hQ-Ss
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 12:01:21 -0400
Received: from mail-pz0-f185.google.com ([209.85.222.185]:35094)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MKDrc-0004F0-AK
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 12:01:21 -0400
Received: by pzk15 with SMTP id 15so1740186pzk.4
	for <qemu-devel@nongnu.org>; Fri, 26 Jun 2009 09:01:18 -0700 (PDT)
Message-ID: <4A44F0C8.8020807@codemonkey.ws>
Date: Fri, 26 Jun 2009 11:01:12 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1245594586.git.mst@redhat.com>
	<20090621164954.GF10164@redhat.com>
	<20090626142635.GD5939@redhat.com>
In-Reply-To: <20090626142635.GD5939@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCHv6 05/12] qemu/pci: MSI-X support functions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, Glauber Costa <glommer@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>

Michael S. Tsirkin wrote:
> On Sun, Jun 21, 2009 at 07:49:54PM +0300, Michael S. Tsirkin wrote:
>   
>> +    dev->msix_mmio_index = cpu_register_io_memory(0, msix_mmio_read,
>> +                                                  msix_mmio_write, dev);
>>     
>
>
> The signature for cpu_register_io_memory changed meanwhile so this now
> needs to be:
>
> +    dev->msix_mmio_index = cpu_register_io_memory(msix_mmio_read,
> +                                                  msix_mmio_write, dev);
>
> Anthony, I guess you figured this out, or do you want me to respin the series
> with this minor fix?
>   

It's already changed in staging.

Regards,

Anthony Liguori