From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLICu-0002aO-NX
	for qemu-devel@nongnu.org; Mon, 29 Jun 2009 10:51:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLICp-0002YL-2J
	for qemu-devel@nongnu.org; Mon, 29 Jun 2009 10:51:42 -0400
Received: from [199.232.76.173] (port=59819 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLICm-0002YB-AJ
	for qemu-devel@nongnu.org; Mon, 29 Jun 2009 10:51:37 -0400
Received: from rv-out-0708.google.com ([209.85.198.249]:34475)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MLICl-0006QB-PQ
	for qemu-devel@nongnu.org; Mon, 29 Jun 2009 10:51:36 -0400
Received: by rv-out-0708.google.com with SMTP id b17so961892rvf.22
	for <qemu-devel@nongnu.org>; Mon, 29 Jun 2009 07:51:34 -0700 (PDT)
Message-ID: <4A48D4F3.3030200@codemonkey.ws>
Date: Mon, 29 Jun 2009 09:51:31 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option.
References: <1246286263-27970-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1246286263-27970-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

Gerd Hoffmann wrote:
> Ok, lets start to collect some low-hanging fruit we can get from the
> qdev bits even at the current early state.
>
> ==> stop adding cmd line switches for each and every device <==
> ==>        do funky stuff you could not do before           <==
>
> Here is a patch adding a generic -pcidevice command line switch.  Works
> only for qdev-converted devices.  Works (for now) only for devices which
> don't need configuration (i.e. nics don't work or maybe use vlan0
> unconditionally).  Most useful with my qdev patch queue applied.
>
> Examples:
>
>   -pcidevice ES1370,addr=42        (replaces -audio es1370).
>   -pcidevice virtio-balloon-pci    (replaces -balloon).
>   -pcidevice lsi53c895a,addr=23    (add scsi adapter in specified slot).
>   -pcidevice "PIIX3 USB-UHCI"      (add second usb bus).
>
> Comments?
>   
You read my mind :-)

I was just thinking about this as I was looking over staging.

What I would like to see is that this internal mechanism be used to 
implement the switches it replaces.  That is, -balloon should just add 
just be a convenience option that expands to -pcidevice.  The same for 
-audio.

Regards,

Anthony Liguori