From: Anthony Liguori <anthony@codemonkey.ws>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Jan Kiszka <jan.kiszka@web.de>,
qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [RESEND][PATCH] KVM: x86: Refactor persistent CPU state
Date: Mon, 29 Jun 2009 14:09:11 -0500 [thread overview]
Message-ID: <4A491157.1030206@codemonkey.ws> (raw)
In-Reply-To: <f43fc5580906280840w191ad496w33adaf908dac714e@mail.gmail.com>
Blue Swirl wrote:
> On 6/27/09, Jan Kiszka <jan.kiszka@web.de> wrote:
>
>> This patch aligns the KVM-related layout and encoding of the CPU state
>> to be saved to disk or migrated with qemu-kvm. The major differences are
>> reordering of fields and a compressed interrupt_bitmap into a single
>> number as there can be no more than one pending IRQ at a time.
>>
>
> This changes the savevm format, shouldn't you bump the version?
>
Practically speaking, it's been bumped for KVM already in this release
cycle so changing the format without bumping the version should be
okay. It may interfere with kvm-XX releases but I'm not sure whether
that's an issue for us and how we should handle that long term.
I'm assuming Jan thought all of this through ahead of time and just
forgot to explicitly state the reasoning for not bumping the version :-)
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-06-29 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-27 7:27 [Qemu-devel] [RESEND][PATCH] KVM: x86: Refactor persistent CPU state Jan Kiszka
2009-06-28 15:40 ` Blue Swirl
2009-06-28 18:10 ` [Qemu-devel] " Jan Kiszka
2009-06-29 19:09 ` Anthony Liguori [this message]
2009-06-29 19:23 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A491157.1030206@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).