From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLMEF-00046N-KU
	for qemu-devel@nongnu.org; Mon, 29 Jun 2009 15:09:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLMEB-00045l-5m
	for qemu-devel@nongnu.org; Mon, 29 Jun 2009 15:09:23 -0400
Received: from [199.232.76.173] (port=40062 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLMEA-00045i-WC
	for qemu-devel@nongnu.org; Mon, 29 Jun 2009 15:09:19 -0400
Received: from mail-ew0-f211.google.com ([209.85.219.211]:56095)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MLMEA-0002OZ-Hj
	for qemu-devel@nongnu.org; Mon, 29 Jun 2009 15:09:18 -0400
Received: by ewy7 with SMTP id 7so5070071ewy.34
	for <qemu-devel@nongnu.org>; Mon, 29 Jun 2009 12:09:17 -0700 (PDT)
Message-ID: <4A491157.1030206@codemonkey.ws>
Date: Mon, 29 Jun 2009 14:09:11 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RESEND][PATCH] KVM: x86: Refactor persistent CPU
	state
References: <4A45C9DA.8030806@web.de>
	<f43fc5580906280840w191ad496w33adaf908dac714e@mail.gmail.com>
In-Reply-To: <f43fc5580906280840w191ad496w33adaf908dac714e@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

Blue Swirl wrote:
> On 6/27/09, Jan Kiszka <jan.kiszka@web.de> wrote:
>   
>> This patch aligns the KVM-related layout and encoding of the CPU state
>>  to be saved to disk or migrated with qemu-kvm. The major differences are
>>  reordering of fields and a compressed interrupt_bitmap into a single
>>  number as there can be no more than one pending IRQ at a time.
>>     
>
> This changes the savevm format, shouldn't you bump the version?
>   

Practically speaking, it's been bumped for KVM already in this release 
cycle so changing the format without bumping the version should be 
okay.  It may interfere with kvm-XX releases but I'm not sure whether 
that's an issue for us and how we should handle that long term.

I'm assuming Jan thought all of this through ahead of time and just 
forgot to explicitly state the reasoning for not bumping the version :-)

Regards,

Anthony Liguori