From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLMRg-0002pd-9S for qemu-devel@nongnu.org; Mon, 29 Jun 2009 15:23:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLMRb-0002iW-GW for qemu-devel@nongnu.org; Mon, 29 Jun 2009 15:23:15 -0400 Received: from [199.232.76.173] (port=46911 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLMRb-0002iP-93 for qemu-devel@nongnu.org; Mon, 29 Jun 2009 15:23:11 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:47466) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLMRa-0004jd-LE for qemu-devel@nongnu.org; Mon, 29 Jun 2009 15:23:11 -0400 Message-ID: <4A491496.3020803@web.de> Date: Mon, 29 Jun 2009 21:23:02 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RESEND][PATCH] KVM: x86: Refactor persistent CPU state References: <4A45C9DA.8030806@web.de> <4A491157.1030206@codemonkey.ws> In-Reply-To: <4A491157.1030206@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2CD2DBFF17429C0C51E33703" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , Anthony Liguori , qemu-devel , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2CD2DBFF17429C0C51E33703 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Blue Swirl wrote: >> On 6/27/09, Jan Kiszka wrote: >> =20 >>> This patch aligns the KVM-related layout and encoding of the CPU stat= e >>> to be saved to disk or migrated with qemu-kvm. The major differences= >>> are >>> reordering of fields and a compressed interrupt_bitmap into a single= >>> number as there can be no more than one pending IRQ at a time. >>> =20 >> >> This changes the savevm format, shouldn't you bump the version? >> =20 >=20 > Practically speaking, it's been bumped for KVM already in this release > cycle so changing the format without bumping the version should be > okay. It may interfere with kvm-XX releases but I'm not sure whether > that's an issue for us and how we should handle that long term. That particular patch is already part of kvm-87. Here we are just aligning both code bases, and that even on the same format version number= =2E >=20 > I'm assuming Jan thought all of this through ahead of time and just > forgot to explicitly state the reasoning for not bumping the version :-= ) Of course, I considered every possible case in every detail. :) Jan --------------enig2CD2DBFF17429C0C51E33703 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEUEARECAAYFAkpJFJsACgkQniDOoMHTA+kaKgCfQtLyC1npBNSTHoC3bEHO5ljw FV8AmME74ha6pI9CK2mRoNjlEdq+kwE= =h+mm -----END PGP SIGNATURE----- --------------enig2CD2DBFF17429C0C51E33703--