From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLYGI-0000U5-Dt for qemu-devel@nongnu.org; Tue, 30 Jun 2009 04:00:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLYGE-0000TZ-UO for qemu-devel@nongnu.org; Tue, 30 Jun 2009 04:00:18 -0400 Received: from [199.232.76.173] (port=43102 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLYGE-0000TW-Rb for qemu-devel@nongnu.org; Tue, 30 Jun 2009 04:00:14 -0400 Received: from mx2.redhat.com ([66.187.237.31]:38359) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLYGE-0002pc-6B for qemu-devel@nongnu.org; Tue, 30 Jun 2009 04:00:14 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5U80Dph016825 for ; Tue, 30 Jun 2009 04:00:13 -0400 Message-ID: <4A49C609.5070002@redhat.com> Date: Tue, 30 Jun 2009 10:00:09 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option. References: <1246286263-27970-1-git-send-email-kraxel@redhat.com> <877hyuda8h.fsf@pike.pond.sub.org> In-Reply-To: <877hyuda8h.fsf@pike.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 06/29/09 23:02, Markus Armbruster wrote: > Why limit this to PCI devices? Good question. I think we can go straight for a -device option. > The device name indirectly specifies the > bus type. Parameter addr then specifies bus instance and device address > on the bus, in a bus-specific syntax. Of course, it's perfectly fine to > implement only PCI initially, but I'd rather not encode that restriction > in the option name :) usb will be easy as well once my patches are in. > To extend this to devices that need configuration: what about > interpreting additional parameters as qdev properties? Oh, there's a > TODO in pci_device_add() that suggests exactly that. cheers, Gerd