From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLZKo-00017Y-5Q
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 05:09:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLZKj-000175-7m
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 05:09:01 -0400
Received: from [199.232.76.173] (port=48793 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLZKj-000172-0R
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 05:08:57 -0400
Received: from mx2.redhat.com ([66.187.237.31]:51034)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MLZKi-000725-GI
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 05:08:56 -0400
Message-ID: <4A49D5E2.4070705@redhat.com>
Date: Tue, 30 Jun 2009 11:07:46 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] EXT3-fs error on Git HEAD
References: <20090629095032.f729525f.mle+tools@mega-nerd.com>	<20090629134201.4115de43.mle+tools@mega-nerd.com>
	<1246292869.13041.342.camel@mendozza.osrc.amd.com>
In-Reply-To: <1246292869.13041.342.camel@mendozza.osrc.amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frank Arnold <frank.arnold@amd.com>
Cc: qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

Frank Arnold schrieb:
> Am Montag, den 29.06.2009, 13:42 +1000 schrieb Erik de Castro Lopo:
>> Erik de Castro Lopo wrote:
>>
>>> I have a number of Qemu VMs. Over the weekend I updated to the latest
>>> Git head and now two of my VMs (one i386 and one x86-64) are having
>>> disk errors. Strange thing is, my arm VM is working flawlessly.
>> These VM disk images are all qcow. The i386 and x86-64 ones I converted
>> to qcow2 and they now work fine. The arm one is still qcow and is still
>> working fine.
> 
> We're seeing the same on qemu-kvm.git. I tracked it down to following
> commits:
> 
> commit c16b5a2ca0b186de618654a576bdad9cdd2d1ab2
> Author: Christoph Hellwig <hch@lst.de>
> Date:   Mon May 25 12:37:32 2009 +0200
> 
>     fully split aio_pool from BlockDriver
> 
> commit ad53089b0d0b4bc0731d978e5713365e1a91ba74
> Author: Christoph Hellwig <hch@lst.de>
> Date:   Mon May 25 15:45:37 2009 +0200
> 
>     qcow: add qcow_aio_setup helper

This one has an obvious bug. Does the following change help?

diff --git a/block/qcow.c b/block/qcow.c
index 55a68a6..7fc85ae 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -723,7 +723,7 @@ static BlockDriverAIOCB
*qcow_aio_writev(BlockDriverState *bs,

     s->cluster_cache_offset = -1; /* disable compressed cache */

-    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 0);
+    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 1);
     if (!acb)
         return NULL;

Kevin