[Qemu-devel] [PATCH] buildfix: unknown option "-Wno-error=uninitialized"

[Qemu-devel] [PATCH] buildfix: unknown option "-Wno-error=uninitialized"

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]


Hi!

Attached patch fixes the build error I get on NetBSD:
(NetBSD comes with gcc 4.1.3)

cc1: error: unrecognized command line option "-Wno-error=uninitialized"

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: qemu_rules.diff --]
[-- Type: text/x-diff, Size: 438 bytes --]

diff --git a/rules.mak b/rules.mak
index defee1d..8561289 100644
--- a/rules.mak
+++ b/rules.mak
@@ -1,6 +1,6 @@
 
 %.o: %.c
-	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
+	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
 
 %.o: %.S
 	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,"  AS    $(TARGET_DIR)$@")

Re: [Qemu-devel] [PATCH] buildfix: unknown option "-Wno-error=uninitialized"

[Avi Kivity]

On 06/30/2009 12:15 PM, Christoph Egger wrote:
> diff --git a/rules.mak b/rules.mak
> index defee1d..8561289 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -1,6 +1,6 @@
>
>   %.o: %.c
> -	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
> +	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
>
>   %.o: %.S
>   	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,"  AS    $(TARGET_DIR)$@")
>    
>


Should remove the -Werror too, it's set by ./configure.

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] buildfix: unknown option "-Wno-error=uninitialized"

[Christoph Egger]

On Tuesday 30 June 2009 12:05:25 Avi Kivity wrote:
> On 06/30/2009 12:15 PM, Christoph Egger wrote:
> > diff --git a/rules.mak b/rules.mak
> > index defee1d..8561289 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -1,6 +1,6 @@
> >
> >   %.o: %.c
> > -	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror
> > -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@") +	$(call
> > quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -c -o $@ $<,"  CC   
> > $(TARGET_DIR)$@")
> >
> >   %.o: %.S
> >   	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,"  AS   
> > $(TARGET_DIR)$@")
>
> Should remove the -Werror too, it's set by ./configure.

Will you do this between applying the patch and 'git commit' or should I 
resend a diff ?

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [Qemu-devel] [PATCH] buildfix: unknown option "-Wno-error=uninitialized"

[Avi Kivity]

On 06/30/2009 01:14 PM, Christoph Egger wrote:
>> Should remove the -Werror too, it's set by ./configure.
>>      
>
> Will you do this between applying the patch and 'git commit' or should I
> resend a diff ?
>
>    

I'm not a qemu maintainer, so I can't commit the patch.

-- 
error compiling committee.c: too many arguments to function