From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLd7C-0001Tw-K4
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:11:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLd78-0001TA-0o
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:11:14 -0400
Received: from [199.232.76.173] (port=52897 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLd77-0001T7-OB
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:11:09 -0400
Received: from e32.co.us.ibm.com ([32.97.110.150]:51922)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1MLd76-00071h-Rf
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:11:09 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e32.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5UD75VP011024
	for <qemu-devel@nongnu.org>; Tue, 30 Jun 2009 07:07:05 -0600
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n5UDAwX4095104
	for <qemu-devel@nongnu.org>; Tue, 30 Jun 2009 07:10:59 -0600
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1])
	by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n5UDAvfb019437
	for <qemu-devel@nongnu.org>; Tue, 30 Jun 2009 07:10:57 -0600
Message-ID: <4A4A0EDF.9040207@us.ibm.com>
Date: Tue, 30 Jun 2009 08:10:55 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio:
	MSI-X support in virtio PCI
References: <200906300055.n5U0tACD013302@d03av01.boulder.ibm.com>
	<761ea48b0906292334o1d5ee2c2r17337d01bd50014c@mail.gmail.com>
	<20090630102552.GE29725@redhat.com>
In-Reply-To: <20090630102552.GE29725@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, qemu-devel@nongnu.org

Michael S. Tsirkin wrote:
> On Tue, Jun 30, 2009 at 08:34:50AM +0200, Laurent Desnogues wrote:
>   
>> On Tue, Jun 30, 2009 at 2:57 AM, Anthony Liguori<aliguori@us.ibm.com> wrote:
>>     
>>> From: Michael S. Tsirkin <mst@redhat.com>
>>>
>>> This enables actual support for MSI-X in virtio PCI.
>>> First user will be virtio-net.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>>       
>> [...]
>>     
>>> diff --git a/rules.mak b/rules.mak
>>> index 8d6d96e..defee1d 100644
>>> --- a/rules.mak
>>> +++ b/rules.mak
>>> @@ -1,6 +1,6 @@
>>>
>>>  %.o: %.c
>>> -       $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
>>> +       $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
>>>       
>> -Wno-error=uninitialized is a rather recent addition to gcc and
>> will probably break compilation on many systems.
>>
>>     

Adding something like this in the middle of a patch, in the middle of a 
big series, is also a really bad thing to do.  If you want to change 
build arguments, it should be a separate patch.

I removed this.  There are no warnings with my GCC.  You can submit 
follow up patches trying to make a case for different ways to handle 
this but please separate this sort of stuff out in the future.

Regards,

Anthony Liguori