From: Anthony Liguori <aliguori@us.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio: MSI-X support in virtio PCI
Date: Tue, 30 Jun 2009 08:14:39 -0500 [thread overview]
Message-ID: <4A4A0FBF.7030702@us.ibm.com> (raw)
In-Reply-To: <4A4A0EDF.9040207@us.ibm.com>
Anthony Liguori wrote:
> Adding something like this in the middle of a patch, in the middle of
> a big series, is also a really bad thing to do. If you want to change
> build arguments, it should be a separate patch.
>
> I removed this. There are no warnings with my GCC. You can submit
> follow up patches trying to make a case for different ways to handle
> this but please separate this sort of stuff out in the future.
Looks like Paul beat me to it.
--
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-06-30 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200906300055.n5U0tACD013302@d03av01.boulder.ibm.com>
2009-06-30 6:34 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio: MSI-X support in virtio PCI Laurent Desnogues
2009-06-30 10:25 ` Michael S. Tsirkin
2009-06-30 13:10 ` Anthony Liguori
2009-06-30 13:14 ` Anthony Liguori [this message]
2009-06-30 13:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4A0FBF.7030702@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=laurent.desnogues@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).