From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLdAe-0002tW-4x for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:14:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLdAZ-0002rp-K6 for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:14:47 -0400 Received: from [199.232.76.173] (port=52997 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLdAZ-0002rm-FC for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:14:43 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:58544) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MLdAZ-0007f3-70 for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:14:43 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e1.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5UD9v22027860 for ; Tue, 30 Jun 2009 09:09:57 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5UDEf1d247596 for ; Tue, 30 Jun 2009 09:14:41 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5UDCGKI005699 for ; Tue, 30 Jun 2009 09:12:16 -0400 Message-ID: <4A4A0FBF.7030702@us.ibm.com> Date: Tue, 30 Jun 2009 08:14:39 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio: MSI-X support in virtio PCI References: <200906300055.n5U0tACD013302@d03av01.boulder.ibm.com> <761ea48b0906292334o1d5ee2c2r17337d01bd50014c@mail.gmail.com> <20090630102552.GE29725@redhat.com> <4A4A0EDF.9040207@us.ibm.com> In-Reply-To: <4A4A0EDF.9040207@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Laurent Desnogues , qemu-devel@nongnu.org Anthony Liguori wrote: > Adding something like this in the middle of a patch, in the middle of > a big series, is also a really bad thing to do. If you want to change > build arguments, it should be a separate patch. > > I removed this. There are no warnings with my GCC. You can submit > follow up patches trying to make a case for different ways to handle > this but please separate this sort of stuff out in the future. Looks like Paul beat me to it. -- Regards, Anthony Liguori