From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened
Date: Tue, 30 Jun 2009 08:32:39 -0500 [thread overview]
Message-ID: <4A4A13F7.8050904@codemonkey.ws> (raw)
In-Reply-To: <4A49CE00.4090504@redhat.com>
Kevin Wolf wrote:
> Avi Kivity schrieb:
>
>> The qcow block driver format is no longer maintained and likely contains
>> serious data corruptors. Urge users to stay away for it, and advertise
>> the new and improved replacement.
>>
>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>
>
> vvfat is using qcow internally, so the warning will appear there, too.
> Not that warning against vvfat would be a bad thing, but this error
> message could be confusing.
>
> Maybe we're lucky enough and vvfat survives a s/qcow/qcow2/, but I
> really never wanted to touch that code...
>
I'm not sure how I feel about this. Can we prove qcow is broken? Is it
only broken for writes and not reads?
If we're printing a warning, does that mean we want to deprecate qcow
and eventually remove it (or remove write support, at least)?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-06-30 13:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 14:04 [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened Avi Kivity
2009-06-30 8:34 ` Kevin Wolf
2009-06-30 13:32 ` Anthony Liguori [this message]
2009-06-30 13:53 ` Kevin Wolf
2009-06-30 13:57 ` Avi Kivity
2009-06-30 14:21 ` Paul Brook
2009-06-30 14:40 ` Daniel P. Berrange
2009-06-30 16:42 ` Anthony Liguori
2009-07-01 17:14 ` Andreas Färber
2009-07-02 7:22 ` Kevin Wolf
2009-06-30 12:05 ` Amit Shah
2009-06-30 12:53 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4A13F7.8050904@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).