From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLdk7-0004a3-Se for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:51:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLdk2-0004WR-CK for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:51:26 -0400 Received: from [199.232.76.173] (port=35536 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLdk2-0004WA-5A for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:51:22 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39077) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLdk1-0003Q6-Mv for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:51:21 -0400 Message-ID: <4A4A18B4.2070004@redhat.com> Date: Tue, 30 Jun 2009 16:52:52 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/11] QMP: Introduce specification file References: <4A412339.5000109@redhat.com> <20090623220204.GA5612@snarc.org> <4A415C30.7030301@us.ibm.com> <20090624010108.GA6537@snarc.org> <4A42200C.6060600@codemonkey.ws> <5b31733c0906240857g546316e0pd92fee9afe6115fa@mail.gmail.com> <4A4252DD.70300@redhat.com> <20090624190539.GR14121@shareable.org> <5b31733c0906241224j50baa7e6lc80b8c79c5d6baa7@mail.gmail.com> <20090624211358.GA14121@shareable.org> <4A43768A.2090604@eu.citrix.com> <4A438FDD.5060206@redhat.com> <4A43935D.6000506@codemonkey.ws> <4A4395B8.4010401@redhat.com> <4A43BD5D.80307@codemonkey.ws> <4A43C264.6060803@redhat.com> <4A43D600.8060605@codemonkey.ws> <4A449113.8070907@redhat.com> <4A44CB74.1070808@codemonkey.ws> <4A44E2F3.8050804@codemonkey.ws> <4A476C60.1080609@redhat.com> <4A47A70B.7070806@codemonkey.ws> <4A47A9B4.4050600@redhat.com> <4A480E0F.6030000@codemonkey.ws> <4A485971.1010000@redhat.com> <4A4922AC.4030707@codemonkey.ws> <4A49A482.30908@redhat.com> <4A4A1390.2050602@codemonkey.ws> In-Reply-To: <4A4A1390.2050602@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "ehabkost@redhat.com" , Stefano Stabellini , "jan.kiszka@siemens.com" , "dlaor@redhat.com" , "qemu-devel@nongnu.org" , Luiz Capitulino , Filip Navara , Vincent Hanquez On 06/30/2009 04:30 PM, Anthony Liguori wrote: > Avi Kivity wrote: >> Writing parsers and emitters should be a required part of writing a >> qemu control program? > > That's what libraries are for. The thing that you still haven't > addressed with JSON, is that there isn't a huge community of JSON > parsers out there. The only json library available in Fedora 10 for C > appears to be json-glib which carries a GObject dependency. > Practically speaking, if we did use JSON, we would have to provide our > own parser library. There are around 100 parsers listed on json.org. We can make the machine protocol optional and dependant on the existence of a json parser of our choice, and Fedora will have to package that dependency if they want to build the machine protocol. Clients are free to use a library or write their own parser. If we provided a parser library it would be useless for all but one client. If we support a common format, clients can reuse an existing library. >>> I will commit a patch series that meets these goals. >> >> We have six months so you'll commit some unreviewed patches now? > > Where does unreviewed come from? Sorry, I understood "I will commit" as "I will personally write and commit", not as "I will commit Luiz's suitably modified patchset". > Why does the emission format have to be perfect in order to start > refactoring the monitor interfaces? There is a large bit of this work > effort that has nothing to do with output format. I don't want to > block that work effort. It does not, and modifying the internals to support a serializable object model can be done in parallel to the json flamewar. -- error compiling committee.c: too many arguments to function