From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option.
Date: Tue, 30 Jun 2009 17:41:21 +0200 [thread overview]
Message-ID: <4A4A3221.3080301@redhat.com> (raw)
In-Reply-To: <87vdmdalmi.fsf@pike.pond.sub.org>
Hi,
> -pcidevice can be useful now, for devices converted to qdev, but it
> doesn't fully work for certain incomplete conversions.
For incomplete conversions it may cause all sorts of strange effects, so
Paul has a point here IMHO.
> While that's
> inacceptable for a release, is it really so horrible as a transient step
> now? Besides, we can easily flag incompletely converted devices, and
> make -pcidevice not touch them.
While thinking about that: We probably need a flag in DeviceInfo anyway
to tag devices which are not supposed to be added via -pcidevice (soon
to be -device). It doesn't make much sense to allow the user adding -
say - interrupt controllers via command line.
Such a flag could also be used to prevent incompletely converted drivers
to be used via -device.
cheers,
Gerd
prev parent reply other threads:[~2009-06-30 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 14:37 [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option Gerd Hoffmann
2009-06-29 14:51 ` Anthony Liguori
2009-06-30 7:55 ` Gerd Hoffmann
2009-06-29 21:02 ` Markus Armbruster
2009-06-30 8:00 ` Gerd Hoffmann
2009-06-30 9:29 ` Gerd Hoffmann
2009-06-30 11:16 ` Paul Brook
2009-06-30 13:37 ` Markus Armbruster
2009-06-30 15:41 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4A3221.3080301@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).