From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLfUb-0004OM-7d
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 11:43:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLfUV-0004M2-W1
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 11:43:32 -0400
Received: from [199.232.76.173] (port=53546 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLfUV-0004Lk-Nh
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 11:43:27 -0400
Received: from mx2.redhat.com ([66.187.237.31]:57203)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MLfUV-00040a-4j
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 11:43:27 -0400
Message-ID: <4A4A3221.3080301@redhat.com>
Date: Tue, 30 Jun 2009 17:41:21 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option.
References: <1246286263-27970-1-git-send-email-kraxel@redhat.com>	<200906301216.41794.paul@codesourcery.com>
	<87vdmdalmi.fsf@pike.pond.sub.org>
In-Reply-To: <87vdmdalmi.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

   Hi,

> -pcidevice can be useful now, for devices converted to qdev, but it
> doesn't fully work for certain incomplete conversions.

For incomplete conversions it may cause all sorts of strange effects, so 
Paul has a point here IMHO.

> While that's
> inacceptable for a release, is it really so horrible as a transient step
> now?  Besides, we can easily flag incompletely converted devices, and
> make -pcidevice not touch them.

While thinking about that:  We probably need a flag in DeviceInfo anyway 
to tag devices which are not supposed to be added via -pcidevice (soon 
to be -device).  It doesn't make much sense to allow the user adding - 
say - interrupt controllers via command line.

Such a flag could also be used to prevent incompletely converted drivers 
to be used via -device.

cheers,
   Gerd