From: Anthony Liguori <anthony@codemonkey.ws>
To: Paul Brook <paul@codesourcery.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened
Date: Tue, 30 Jun 2009 11:42:45 -0500 [thread overview]
Message-ID: <4A4A4085.9020601@codemonkey.ws> (raw)
In-Reply-To: <200906301521.26152.paul@codesourcery.com>
Paul Brook wrote:
> IMHO there's little value in just printing a warning. Until it actually goes
> away, people are liable to assume we're just being paranoid/awkward and keep
> using it anyway.
>
> I suggest crippling it now and, assuming noone steps up to fix+maintain it,
> ripping out the write support altogether at next release.
> I'm assuming the readonly code is in better shape, and can be supported with
> relatively little effort.
>
Yes, that's what I was getting at. We need to support read-only in
order to allow people to convert to qcow2.
If we're sufficiently concerned that there is data corruption in the
write path, we should disable it to keep a user from shooting themselves
in the foot.
Regards,
Anthony Liguori
> Paul
>
next prev parent reply other threads:[~2009-06-30 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 14:04 [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened Avi Kivity
2009-06-30 8:34 ` Kevin Wolf
2009-06-30 13:32 ` Anthony Liguori
2009-06-30 13:53 ` Kevin Wolf
2009-06-30 13:57 ` Avi Kivity
2009-06-30 14:21 ` Paul Brook
2009-06-30 14:40 ` Daniel P. Berrange
2009-06-30 16:42 ` Anthony Liguori [this message]
2009-07-01 17:14 ` Andreas Färber
2009-07-02 7:22 ` Kevin Wolf
2009-06-30 12:05 ` Amit Shah
2009-06-30 12:53 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4A4085.9020601@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).