From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLgQ5-0004xa-5t
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:42:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLgQ0-0004wj-Cp
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:42:56 -0400
Received: from [199.232.76.173] (port=50488 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLgQ0-0004wg-9Z
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:42:52 -0400
Received: from ey-out-2122.google.com ([74.125.78.24]:2080)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MLgPz-0005VB-VR
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:42:52 -0400
Received: by ey-out-2122.google.com with SMTP id 22so72858eye.57
	for <qemu-devel@nongnu.org>; Tue, 30 Jun 2009 09:42:51 -0700 (PDT)
Message-ID: <4A4A4085.9020601@codemonkey.ws>
Date: Tue, 30 Jun 2009 11:42:45 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened
References: <1246284289-25394-1-git-send-email-avi@redhat.com>
	<4A4A13F7.8050904@codemonkey.ws> <4A4A19B7.3070600@redhat.com>
	<200906301521.26152.paul@codesourcery.com>
In-Reply-To: <200906301521.26152.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>

Paul Brook wrote:
> IMHO there's little value in just printing a warning. Until it actually goes 
> away, people are liable to assume we're just being paranoid/awkward and keep 
> using it anyway.
>
> I suggest crippling it now and, assuming noone steps up to fix+maintain it, 
> ripping out the write support altogether at next release.
> I'm assuming the readonly code is in better shape, and can be supported with 
> relatively little effort.
>   

Yes, that's what I was getting at.  We need to support read-only in 
order to allow people to convert to qcow2.

If we're sufficiently concerned that there is data corruption in the 
write path, we should disable it to keep a user from shooting themselves 
in the foot.

Regards,

Anthony Liguori

> Paul
>