From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev
Date: Tue, 30 Jun 2009 18:55:13 +0200 [thread overview]
Message-ID: <4A4A4371.8020409@redhat.com> (raw)
In-Reply-To: <20090630165043.GA1159@lst.de>
Christoph Hellwig schrieb:
> On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
>> Pass is_write = 1 to qcow_aio_setup when writing.
>
> Looks correct, sorry for introducing this.
>
> Maybe we should add symbolic names for READ/WRITE in another patch to
> make this more easily spottable?
I'd expect we'll not see such things in the same place again, but
symbolic constants are always better. Are you going to prepare a patch?
Kevin
next prev parent reply other threads:[~2009-06-30 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 13:37 [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev Kevin Wolf
2009-06-30 16:50 ` Christoph Hellwig
2009-06-30 16:55 ` Kevin Wolf [this message]
2009-06-30 16:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4A4371.8020409@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).