From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLgdA-000275-Fy for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:56:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLgd5-000245-Ks for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:56:27 -0400 Received: from [199.232.76.173] (port=52957 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLgd5-00023z-G7 for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:56:23 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54459) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLgd4-0007XY-SF for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:56:23 -0400 Message-ID: <4A4A4371.8020409@redhat.com> Date: Tue, 30 Jun 2009 18:55:13 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev References: <1246369037-2845-1-git-send-email-kwolf@redhat.com> <20090630165043.GA1159@lst.de> In-Reply-To: <20090630165043.GA1159@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Christoph Hellwig schrieb: > On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote: >> Pass is_write = 1 to qcow_aio_setup when writing. > > Looks correct, sorry for introducing this. > > Maybe we should add symbolic names for READ/WRITE in another patch to > make this more easily spottable? I'd expect we'll not see such things in the same place again, but symbolic constants are always better. Are you going to prepare a patch? Kevin