From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLjKr-0005Hu-04
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 15:49:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLjKm-00056l-2f
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 15:49:44 -0400
Received: from [199.232.76.173] (port=60039 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLjKl-00056L-T8
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 15:49:39 -0400
Received: from ey-out-2122.google.com ([74.125.78.25]:36920)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MLjKl-0001FI-Gp
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 15:49:39 -0400
Received: by ey-out-2122.google.com with SMTP id 22so105386eye.57
	for <qemu-devel@nongnu.org>; Tue, 30 Jun 2009 12:49:34 -0700 (PDT)
Message-ID: <4A4A6C48.3060101@codemonkey.ws>
Date: Tue, 30 Jun 2009 14:49:28 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/8] qdev/core: bus list
References: <1246353962-32308-1-git-send-email-kraxel@redhat.com>	<200906301218.35086.paul@codesourcery.com>	<87k52t8xvk.fsf@pike.pond.sub.org>	<200906301821.18245.paul@codesourcery.com>
	<87ab3p7cbh.fsf@pike.pond.sub.org>
In-Reply-To: <87ab3p7cbh.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

Markus Armbruster wrote:
> Paul Brook <paul@codesourcery.com> writes:
>
>   
>> On Tuesday 30 June 2009, Markus Armbruster wrote:
>>     
>>> Paul Brook <paul@codesourcery.com> writes:
>>>       
>>>> On Tuesday 30 June 2009, Gerd Hoffmann wrote:
>>>>         
>>>>>  * maintain a list of busses.
>>>>>  * maintain bus numbers.
>>>>>  * add function to find busses by type / name / number.
>>>>>  * add monitor command to list busses.
>>>>>           
>>>> I still object to this patch. Busses should be identified by their
>>>> location in the tree, not by number.
>>>>
>>>> Paul
>>>>         
>>> Location in the tree can be uniquely identified by a number.  Handy when
>>> all you want is enumerate the buses, and you don't really care where
>>> they're hanging out in the tree.  Why should something like that not be
>>> done?
>>>       
>> The address of the BusState is also a locally unique identifier. That doesn't 
>> mean it's a good thing to expose to the user.
>>
>> Paul
>>     
>
> Red herring.
>   

I don't think that's a very useful response.

I think it's a perfectly valid suggestion that we should identify buses 
based on the their location in the tree to users verses a number 
generated based on some hashing algorithm.

A tree location has meaning to a user.  A random integer doesn't.

Regards,

Anthony Liguori