From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLjp9-00073Z-Qr
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 16:21:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLjp4-0006yY-OD
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 16:21:03 -0400
Received: from [199.232.76.173] (port=57429 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLjp4-0006yJ-GB
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 16:20:58 -0400
Received: from mx2.redhat.com ([66.187.237.31]:55206)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MLjp4-0006lC-6t
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 16:20:58 -0400
Message-ID: <4A4A731D.5020306@redhat.com>
Date: Tue, 30 Jun 2009 22:18:37 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/8] qdev/core: bus list
References: <1246353962-32308-1-git-send-email-kraxel@redhat.com>	<200906301218.35086.paul@codesourcery.com>	<87k52t8xvk.fsf@pike.pond.sub.org>	<200906301821.18245.paul@codesourcery.com>
	<87ab3p7cbh.fsf@pike.pond.sub.org> <4A4A6C48.3060101@codemonkey.ws>
In-Reply-To: <4A4A6C48.3060101@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Paul Brook <paul@codesourcery.com>

On 06/30/09 21:49, Anthony Liguori wrote:
> I think it's a perfectly valid suggestion that we should identify buses
> based on the their location in the tree to users verses a number
> generated based on some hashing algorithm.
 >
> A tree location has meaning to a user. A random integer doesn't.

Well.  Depends on the bus I think.  About PCI devices the usual user 
probably thinks in terms of "$bus:$slot.$function", which includes a bus 
number.

Speaking of PCI: the PCI bus number (aka PCIBus->bus_num) has nothing to 
do with the more or less random bus number introduced by the (now 
dropped) patch (aka PCIBus->qdev.busnr).  Which indicates that it is 
probably less confusing to have the bus implementation handle the 
enumeration of busses.  If it makes sense for the bus in question of 
course.  sysbus probably doesn't care ;)

cheers,
   Gerd