From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLvJD-0004XE-IE
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 04:36:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLvJ8-0004Ux-Gk
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 04:36:50 -0400
Received: from [199.232.76.173] (port=42658 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLvJ8-0004Us-AQ
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 04:36:46 -0400
Received: from mx2.redhat.com ([66.187.237.31]:51166)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MLvJ7-0006RR-Qf
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 04:36:46 -0400
Message-ID: <4A4B1FDA.9090006@redhat.com>
Date: Wed, 01 Jul 2009 10:35:38 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <200906300055.n5U0tACE013302@d03av01.boulder.ibm.com>
In-Reply-To: <200906300055.n5U0tACE013302@d03av01.boulder.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [COMMIT ff24bd5] qemu/virtio: virtio save/load
	bindings
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

Anthony Liguori schrieb:
> From: Michael S. Tsirkin <mst@redhat.com>
>=20
> Implement bindings for virtio save/load. Use them in virtio pci.
>=20
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

This patch causes segfaults during savevm:

Program received signal SIGSEGV, Segmentation fault.
0x0000003d1d0842a2 in memcpy () from /lib64/libc.so.6
(gdb) bt
#0  0x0000003d1d0842a2 in memcpy () from /lib64/libc.so.6
#1  0x00000000004a65bf in qemu_put_buffer (f=3D0xd4f220, buf=3D0x0, size=3D=
48)
at savevm.c:478
#2  0x0000000000419133 in msix_save (dev=3D0xc93410, f=3D0xd4f220) at
/home/kwolf/source/qemu/hw/msix.c:289
#3  0x0000000000555424 in virtio_pci_save_config (opaque=3D0xc93410,
f=3D0xd4f220) at /home/kwolf/source/qemu/hw/virtio-pci.c:112
#4  0x00000000005545b3 in virtio_save (vdev=3D0xc93ad0, f=3D0xd4f220) at
/home/kwolf/source/qemu/hw/virtio.c:620
#5  0x0000000000419eaf in virtio_balloon_save (f=3D0xd4f220,
opaque=3D0xc93ad0) at /home/kwolf/source/qemu/hw/virtio-balloon.c:151
#6  0x00000000004a6756 in qemu_savevm_state_complete (f=3D0xd4f220) at
savevm.c:811
#7  0x00000000004a68dd in qemu_savevm_state (f=3D0xd4f220) at savevm.c:84=
2
#8  0x00000000004a6a4b in do_savevm (mon=3D0xcd87b0, name=3D<value optimi=
zed
out>) at savevm.c:1134
#9  0x00000000004138f4 in monitor_handle_command (mon=3D0xcd87b0,
cmdline=3D<value optimized out>) at /home/kwolf/source/qemu/monitor.c:269=
7
#10 0x00000000004139ba in monitor_command_cb (mon=3D0xcd87b0, cmdline=3D0=
x0,
opaque=3D0x30) at /home/kwolf/source/qemu/monitor.c:2964
#11 0x000000000047cc74 in readline_handle_byte (rs=3D0xcb7aa0, ch=3D<valu=
e
optimized out>) at readline.c:369
#12 0x0000000000413a24 in monitor_read (opaque=3D<value optimized out>,
buf=3D0x7fffffffc6b0 "\r=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD\177", size=3D=
1)
    at /home/kwolf/source/qemu/monitor.c:2950
#13 0x00000000004a33e3 in qemu_chr_read (len=3D<value optimized out>,
buf=3D<value optimized out>, s=3D<value optimized out>) at qemu-char.c:16=
8
#14 fd_chr_read (opaque=3D<value optimized out>) at qemu-char.c:571
#15 0x0000000000409d92 in main_loop_wait (timeout=3D<value optimized out>=
)
at /home/kwolf/source/qemu/vl.c:4273
#16 0x000000000040dbdd in main_loop () at /home/kwolf/source/qemu/vl.c:44=
99
#17 main (argc=3D6, argv=3D0x7fffffffe178, envp=3D<value optimized out>) =
at
/home/kwolf/source/qemu/vl.c:6252

I guess it's easy to reproduce with any setup, just for completeness
here is what I did:

$ ./qemu-img create -f qcow2 images/tmp.qcow2 1M
$ x86_64-softmmu/qemu-system-x86_64 -L pc-bios/ images/tmp.qcow2
-monitor stdio <<< savevm test

Kevin