From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLzsW-0002es-A2
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 09:29:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLzsO-0002Re-3Y
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 09:29:33 -0400
Received: from [199.232.76.173] (port=59932 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLzsN-0002RH-7m
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 09:29:27 -0400
Received: from mail-qy0-f191.google.com ([209.85.221.191]:34819)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MLzsM-00032Y-Lm
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 09:29:26 -0400
Received: by qyk29 with SMTP id 29so971920qyk.4
	for <qemu-devel@nongnu.org>; Wed, 01 Jul 2009 06:29:26 -0700 (PDT)
Message-ID: <4A4B64B2.3040106@codemonkey.ws>
Date: Wed, 01 Jul 2009 08:29:22 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Allow setting qemu process name
References: <20090701093251.GA12447@basil.fritz.box>
In-Reply-To: <20090701093251.GA12447@basil.fritz.box>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andi Kleen <andi@firstfloor.org>
Cc: qemu-devel@nongnu.org

Andi Kleen wrote:
> [this is a port of a old KVM userland patch I had; Avi back then suggested to 
> submit it to qemu]
>
> Set the Linux process name to the name argument specified with "-name". I find
> this useful to see which guests are taking CPU time in top.
>   

This is not a bad idea but it has to be optional and non-default.  Maybe 
a new command line option?

>  /***************/
>  /* ballooning */
> @@ -6008,11 +6022,15 @@ int main(int argc, char **argv, char **envp)
>      if (kvm_enabled()) {
>          int ret;
>  
> +        set_proc_name("kvm", qemu_name);
> +
>          ret = kvm_init(smp_cpus);
>          if (ret < 0) {
>              fprintf(stderr, "failed to initialize KVM\n");
>              exit(1);
>          }
> +    } else {
> +        set_proc_name("qemu", qemu_name);
>      }

I'd rather see qemu be the prefix unconditionally.

Regards,

Anthony Liguori

>  
>      if (monitor_device) {
>