From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MM1O8-00039S-18 for qemu-devel@nongnu.org; Wed, 01 Jul 2009 11:06:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MM1O2-00039G-MH for qemu-devel@nongnu.org; Wed, 01 Jul 2009 11:06:18 -0400 Received: from [199.232.76.173] (port=36160 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MM1O2-00039D-Gk for qemu-devel@nongnu.org; Wed, 01 Jul 2009 11:06:14 -0400 Received: from mx2.redhat.com ([66.187.237.31]:59841) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MM1O1-0003Fb-9U for qemu-devel@nongnu.org; Wed, 01 Jul 2009 11:06:14 -0400 Message-ID: <4A4B7BC6.8080407@redhat.com> Date: Wed, 01 Jul 2009 18:07:50 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Allow setting qemu process name References: <20090701093251.GA12447@basil.fritz.box> <4A4B64B2.3040106@codemonkey.ws> In-Reply-To: <4A4B64B2.3040106@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Andi Kleen , qemu-devel@nongnu.org On 07/01/2009 04:29 PM, Anthony Liguori wrote: > Andi Kleen wrote: >> [this is a port of a old KVM userland patch I had; Avi back then >> suggested to submit it to qemu] >> >> Set the Linux process name to the name argument specified with >> "-name". I find >> this useful to see which guests are taking CPU time in top. > > This is not a bad idea but it has to be optional and non-default. > Maybe a new command line option? -name [title=]blah[,process=foobar] > + } else { > + set_proc_name("qemu", qemu_name); > } > > I'd rather see qemu be the prefix unconditionally. Why have a prefix at all? The user can add it if they're so inclined. -- error compiling committee.c: too many arguments to function