From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MM1QK-000469-PH
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 11:08:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MM1QG-000438-56
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 11:08:36 -0400
Received: from [199.232.76.173] (port=36199 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MM1QF-000431-Sf
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 11:08:31 -0400
Received: from mx2.redhat.com ([66.187.237.31]:52573)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MM1QE-0003nS-6v
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 11:08:30 -0400
Message-ID: <4A4B7C53.4030306@redhat.com>
Date: Wed, 01 Jul 2009 18:10:11 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Set a useful default for kerneldir
References: <20090701093319.GA12461@basil.fritz.box>
	<4A4B653B.5010203@codemonkey.ws>
In-Reply-To: <4A4B653B.5010203@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Andi Kleen <andi@firstfloor.org>, qemu-devel@nongnu.org

On 07/01/2009 04:31 PM, Anthony Liguori wrote:
> Andi Kleen wrote:
>> When no explicit kerneldir is specified use the standard
>> /lib/modules/$(uname -r)/build
>> convention to find the kernel includes. This should work out of the 
>> box on a large number of distributions.
>>
>> Also support separate objdirs.
>>
>> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> The reason we don't specify an explicit include is that it makes it 
> possible to have a cross compiler with headers installed in the cross 
> compilers root.  If you default to /lib/modules, you have to 
> explicitly override it when cross compiling.
>
> Another option would be to just include the KVM headers in QEMU.

Or to have kvm-kmod install the headers in /usr/local/include.  I'm wary 
about that though, it makes qemu features depend on the installation 
order of qemu and kvm-kmod.

-- 
error compiling committee.c: too many arguments to function