[Qemu-devel] [PATCH] Set a useful default for kerneldir

[Qemu-devel] [PATCH] Set a useful default for kerneldir

[Andi Kleen]

When no explicit kerneldir is specified use the standard
/lib/modules/$(uname -r)/build
convention to find the kernel includes. This should work out of the box 
on a large number of distributions.

Also support separate objdirs.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

diff --git a/configure b/configure
index eb9d73a..8c2491d 100755
--- a/configure
+++ b/configure
@@ -1148,6 +1148,13 @@ if test "$kvm" = "yes" ; then
 #endif
 int main(void) { return 0; }
 EOF
+  if test "$kerneldir" = "" ; then
+      kerneldir="/lib/modules/`uname -r`/build"
+      if test -d "$kerneldir/source" ; then
+          kerneldir="$kerneldir/source"
+      fi
+  fi
+  echo "Kerneldir         $kerneldir"
   if test "$kerneldir" != "" ; then
       kvm_cflags=-I"$kerneldir"/include
       if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) \

-- 
ak@linux.intel.com -- Speaking for myself only.

Re: [Qemu-devel] [PATCH] Set a useful default for kerneldir

[Anthony Liguori]

Andi Kleen wrote:
> When no explicit kerneldir is specified use the standard
> /lib/modules/$(uname -r)/build
> convention to find the kernel includes. This should work out of the box 
> on a large number of distributions.
>
> Also support separate objdirs.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>   

The reason we don't specify an explicit include is that it makes it 
possible to have a cross compiler with headers installed in the cross 
compilers root.  If you default to /lib/modules, you have to explicitly 
override it when cross compiling.

Another option would be to just include the KVM headers in QEMU.

Regards,

Anthony Liguori

Re: [Qemu-devel] [PATCH] Set a useful default for kerneldir

[Andi Kleen]

On Wed, Jul 01, 2009 at 08:31:39AM -0500, Anthony Liguori wrote:
> The reason we don't specify an explicit include is that it makes it 
> possible to have a cross compiler with headers installed in the cross 
> compilers root.  If you default to /lib/modules, you have to explicitly 
> override it when cross compiling.

You can still override it for special cases. This is just a better
default than /usr/include which is near always wrong.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.

Re: [Qemu-devel] [PATCH] Set a useful default for kerneldir

[Avi Kivity]

On 07/01/2009 04:31 PM, Anthony Liguori wrote:
> Andi Kleen wrote:
>> When no explicit kerneldir is specified use the standard
>> /lib/modules/$(uname -r)/build
>> convention to find the kernel includes. This should work out of the 
>> box on a large number of distributions.
>>
>> Also support separate objdirs.
>>
>> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> The reason we don't specify an explicit include is that it makes it 
> possible to have a cross compiler with headers installed in the cross 
> compilers root.  If you default to /lib/modules, you have to 
> explicitly override it when cross compiling.
>
> Another option would be to just include the KVM headers in QEMU.

Or to have kvm-kmod install the headers in /usr/local/include.  I'm wary 
about that though, it makes qemu features depend on the installation 
order of qemu and kvm-kmod.

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] Set a useful default for kerneldir

[Anthony Liguori]

Andi Kleen wrote:
> When no explicit kerneldir is specified use the standard
> /lib/modules/$(uname -r)/build
> convention to find the kernel includes. This should work out of the box 
> on a large number of distributions.
>
> Also support separate objdirs.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> diff --git a/configure b/configure
> index eb9d73a..8c2491d 100755
> --- a/configure
> +++ b/configure
> @@ -1148,6 +1148,13 @@ if test "$kvm" = "yes" ; then
>  #endif
>  int main(void) { return 0; }
>  EOF
> +  if test "$kerneldir" = "" ; then
> +      kerneldir="/lib/modules/`uname -r`/build"
> +      if test -d "$kerneldir/source" ; then
> +          kerneldir="$kerneldir/source"
> +      fi
> +  fi
> +  echo "Kerneldir         $kerneldir"
>   

This is the wrong place for this echo.  They're all unified in a block 
further down in the code.

Regards,

Anthony Liguori