From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MM4nO-00051s-BE
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 14:44:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MM4nJ-0004zl-Kl
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 14:44:37 -0400
Received: from [199.232.76.173] (port=58267 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MM4nJ-0004ze-Em
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 14:44:33 -0400
Received: from rv-out-0708.google.com ([209.85.198.245]:28518)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MM4nI-0004OL-Te
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 14:44:33 -0400
Received: by rv-out-0708.google.com with SMTP id b17so333918rvf.22
	for <qemu-devel@nongnu.org>; Wed, 01 Jul 2009 11:44:31 -0700 (PDT)
Message-ID: <4A4BAE8B.1080206@codemonkey.ws>
Date: Wed, 01 Jul 2009 13:44:27 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] VNC char device data stream tunnelling
References: <20090701162114.GB24296@redhat.com>
	<20090701162747.GD24296@redhat.com>
In-Reply-To: <20090701162747.GD24296@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

Daniel P. Berrange wrote:
> +/*
> + * Encoding #: -260
> + *
> + * The server notifies the client of available streams using the
> + * framebuffer update for our psuedo encoding #.
> + *
> + * The 'x' field is '0' for a device addition, '1' for removal
> + *
> + * The payload of the update is the device name
> + *  - u32 - length of device name
> + *  - u8 * len - text of device name, not including \0
> + *
> + * When client indicates it accepts the stream encoding,
> + * the server will send back a stream addition update for
> + * each initial device. Hotplug/unplug for streams will
> + * trigger further updates.
> + *
> + * For QEMU, the streams extension maps 1-stream to 1 char device
> + *
> + * Stream capture uses an new 'aliguori' message sub-type. There
> + * are 3 client -> server messages, and 3 server -> client messages
> + *
> + * Client starts capture by supplying a stream name. Server replies
> + * givng the stream name -> stream ID mapping. All further messages
> + * use the unique stream ID.
> + *
> + * Client -> server messages:
> + *
> + *   Message   == u8: 255 (aliguouri)
> + *   sub-type  == u8: 2  (streams)
> + *   operation == u8:
> + *        0 == start capture
> + *        1 == end capture
> + *        2 == send data
> + *
> + * For operation == start capture:
> + *   content:
> + *      u32 - length of device name
> + *      u8 *len - device name to capture
> + *
> + * For operation == end capture
> + *   content:
> + *      u32 - capture session ID
> + *
> + * For operation == send data
> + *   content:
> + *      u32 - capture session ID
> + *      u32 - length of data
> + *      u8*len - raw data
> + *
> + *
> + *
> + * Server -> client messages:
> + *
> + *   Message   == u8: 255 (aliguouri)
> + *   sub-type  == u8: 2  (streams)
> + *   operation == u8:
> + *        0 == start capture
> + *        1 == end capture
> + *        2 == send data
> + *
> + * For operation == start capture
> + *   content:
> + *      u32 - capture session ID
> + *      u32 - length of device name
> + *      u8 *len - device name to capture
> + *
> + * For operation == end capture
> + *   content:
> + *      u32 - capture session ID
> + *
> + * For operation == send data
> + *   content:
> + *      u32 - capture session ID
> + *      u32 - length of data
> + *      u8*len - raw data
> + *

Acked-by: Anthony Liguori <aliguori@us.ibm.com> on the protocol encoding

Do you have gtk-vnc patches yet?

Regards,

Anthony Liguori