From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MMJGX-000684-91 for qemu-devel@nongnu.org; Thu, 02 Jul 2009 06:11:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MMJGS-00066S-Jv for qemu-devel@nongnu.org; Thu, 02 Jul 2009 06:11:40 -0400 Received: from [199.232.76.173] (port=55720 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MMJGS-00066O-9x for qemu-devel@nongnu.org; Thu, 02 Jul 2009 06:11:36 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48677) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MMJGR-0004zs-VA for qemu-devel@nongnu.org; Thu, 02 Jul 2009 06:11:36 -0400 Message-ID: <4A4C8844.4070209@redhat.com> Date: Thu, 02 Jul 2009 13:13:24 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4A4C8686.4020908@amd.com> In-Reply-To: <4A4C8686.4020908@amd.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: target-i386/kvm.c vs. qemu-kvm-x86.c List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/02/2009 01:05 PM, Andre Przywara wrote: > Hi, > > the lastest qemu -> qemu-kvm sync pulled the kvm_trim_features() > function from QEMU's target-i386/kvm.c into the qemu-kvm tree, where > it is already defined in qemu-kvm-x86.c (which does not exist in > qemu.git). > AFAICS qemu-kvm only uses the last file, so the target-i386 code is > not triggered. > What is the future of these two files? Will one vanish? Will they be > merged? Where to put new features in? All of the above. The goal is to merge the features of qemu-kvm.c and qemu-kvm-x86.c into kvm-all.c and kvm.c, eventually removing the former. In general new features need to be added in both. -- error compiling committee.c: too many arguments to function