From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MMJR8-0002Lt-Nd
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 06:22:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MMJR3-0002IZ-Lf
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 06:22:37 -0400
Received: from [199.232.76.173] (port=59815 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MMJR3-0002IQ-EO
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 06:22:33 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48639)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MMJR3-0006pH-2b
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 06:22:33 -0400
Message-ID: <4A4C8A24.70209@redhat.com>
Date: Thu, 02 Jul 2009 12:21:24 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: PATCH: Add 3C90X emulation
References: <f88ae150905050056vbf491b1wa8ed9d30631de8a@mail.gmail.com>	<6D22281B668644418902B6130F779008@FSCPC>	<f88ae150906020410k270280d8k1d1c77f168e06ce8@mail.gmail.com>	<f88ae150906020410rba503b9rc2a315682cda2686@mail.gmail.com>	<BE7264EAB2E149D4B82BEAFF6BC68198@FSCPC>	<f88ae150906021635k34fcbeebx5e533c49d6f1875a@mail.gmail.com>	<f88ae150906030219s7102599h80749b4653fcb2e4@mail.gmail.com>	<EE2BA4D82E644425BA529D5A9D43F756@FSCPC>	<f88ae150906031520nf8a724ck3f42162a36b3a1ff@mail.gmail.com>
	<f88ae150907020301n310a9ab8vcbd2995d6783c07a@mail.gmail.com>
In-Reply-To: <f88ae150907020301n310a9ab8vcbd2995d6783c07a@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Matthew Iselin <matthew@theiselins.net>
Cc: qemu-devel@nongnu.org

Matthew Iselin schrieb:
> Hi,
> 
> After a long break in which I wasn't able to actually get access to a
> system to create the patch on, I present this patch, which applies
> cleanly to commit 3da6abd472200bc30b88d5a900ad316d9517d163 ("Use
> pstrcpy and pstrcat to avoid OpenBSD linker warning").

I think you forgot something... ;-)

Also, if you want the patch to merged you should send a proper patch
description that can serve as a commit message, including a
Signed-off-by line. You don't seem to have included this in the previous
attempts.

Kevin