From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MMRYX-0004dZ-0y
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 15:02:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MMRYS-0004bi-Dz
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 15:02:48 -0400
Received: from [199.232.76.173] (port=40726 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MMRYR-0004bb-S0
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 15:02:43 -0400
Received: from rv-out-0708.google.com ([209.85.198.250]:35568)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MMRYR-0004iI-AT
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 15:02:43 -0400
Received: by rv-out-0708.google.com with SMTP id b17so570466rvf.22
	for <qemu-devel@nongnu.org>; Thu, 02 Jul 2009 12:02:42 -0700 (PDT)
Message-ID: <4A4D044D.7020003@codemonkey.ws>
Date: Thu, 02 Jul 2009 14:02:37 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Replace signrom with shell script v3
References: <1246478901-6623-1-git-send-email-agraf@suse.de>	<f43fc5580907021052i263a2b0fpbdb1ea7c4cd3173@mail.gmail.com>
	<f43fc5580907021107i5ae13305m21f954ba239a9638@mail.gmail.com>
In-Reply-To: <f43fc5580907021107i5ae13305m21f954ba239a9638@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

Blue Swirl wrote:
> On 7/2/09, Blue Swirl <blauwirbel@gmail.com> wrote:
>   
>> On 7/1/09, Alexander Graf <agraf@suse.de> wrote:
>>  > In order to not execute code we just compiled, let's replace signrom
>>  >  with a shell script that does the same thing while staying compatible
>>  >  to pretty much every system available.
>>  >
>>  >  This should make cross-compilation for windows easier.
>>
>>
>> Why don't you use $(HOST_CC) to compile the signrom binary?
>>
>>     
>
> Like with this patch? Fixes Mingw32 compile for me.
>   

If you're cross compiling, HOST_CC is the wrong compiler to use for the 
ROM build.  For instance, if you were on a PPC host building an i386 
QEMU package.

Building signrom with HOST_CC may be reasonable.

Regards,

Anthony Liguori