From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MMzUX-0005VY-3Z
	for qemu-devel@nongnu.org; Sat, 04 Jul 2009 03:16:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MMzUR-0005O0-Lo
	for qemu-devel@nongnu.org; Sat, 04 Jul 2009 03:16:55 -0400
Received: from [199.232.76.173] (port=49459 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MMzUR-0005Np-DC
	for qemu-devel@nongnu.org; Sat, 04 Jul 2009 03:16:51 -0400
Received: from mx20.gnu.org ([199.232.41.8]:43988)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jan.kiszka@web.de>) id 1MMzUQ-00079y-OQ
	for qemu-devel@nongnu.org; Sat, 04 Jul 2009 03:16:50 -0400
Received: from fmmailgate03.web.de ([217.72.192.234])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MMzUO-0005QM-DW
	for qemu-devel@nongnu.org; Sat, 04 Jul 2009 03:16:48 -0400
Message-ID: <4A4F01D8.7090805@web.de>
Date: Sat, 04 Jul 2009 09:16:40 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll
References: <4A4BC57E.504@web.de> <4A4C5C0E.2050502@web.de>
	<4A4C5DA9.8020909@web.de>
	<200907031035.20520.paul@codesourcery.com>
In-Reply-To: <200907031035.20520.paul@codesourcery.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigEB032EF480C8481DC453BAEB"
Sender: jan.kiszka@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigEB032EF480C8481DC453BAEB
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Paul Brook wrote:
> On Thursday 02 July 2009, Jan Kiszka wrote:
>> Not all host platforms support ffsll.
>=20
>> -            pending_irq =3D i * 64 + bit - 1;
>> +            bit =3D ctz64(env->interrupt_bitmap[i]);
>> +            pending_irq =3D i * 64 + bit;
>=20
> Are we sure there is only ever one bit set in interrupt_bitmap?

Yes.

> If not does it mater that we're processing them in reverse order?
>=20
> Paul

Jan


--------------enigEB032EF480C8481DC453BAEB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkpPAdwACgkQniDOoMHTA+lZNQCcDDkGwzo9iMyxKbg5loJtKpJg
n2oAn17tWI5H5IcdkiYVo4l03Vg0TsBJ
=vm7H
-----END PGP SIGNATURE-----

--------------enigEB032EF480C8481DC453BAEB--