From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNNYU-0001X7-4N for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:58:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNNYN-0001No-Tm for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:58:36 -0400 Received: from [199.232.76.173] (port=40441 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNNYN-0001NH-N3 for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:58:31 -0400 Received: from mx2.redhat.com ([66.187.237.31]:44144) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MNNYN-00069c-6e for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:58:31 -0400 Message-ID: <4A506BB5.4010602@redhat.com> Date: Sun, 05 Jul 2009 12:00:37 +0300 From: Avi Kivity MIME-Version: 1.0 References: <200907050826.n658QVBa024976@d03av04.boulder.ibm.com> In-Reply-To: <200907050826.n658QVBa024976@d03av04.boulder.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 98846d7] Fix Sparse warning List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel On 07/05/2009 11:28 AM, Anthony Liguori wrote: > From: Blue Swirl > > Signed-off-by: Blue Swirl > > diff --git a/hw/msix.c b/hw/msix.c > index 4ab6da6..c031842 100644 > --- a/hw/msix.c > +++ b/hw/msix.c > @@ -296,8 +296,9 @@ void msix_load(PCIDevice *dev, QEMUFile *f) > { > unsigned n = dev->msix_entries_nr; > > - if (!dev->cap_present& QEMU_PCI_CAP_MSIX) > + if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) { > return; > + } > > This is more than a sparse warning fix; it fixes a genuine bug. -- error compiling committee.c: too many arguments to function