From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNQSv-0006K8-Eh for qemu-devel@nongnu.org; Sun, 05 Jul 2009 08:05:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNQSq-00068R-P7 for qemu-devel@nongnu.org; Sun, 05 Jul 2009 08:05:05 -0400 Received: from [199.232.76.173] (port=41983 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNQSq-000680-Km for qemu-devel@nongnu.org; Sun, 05 Jul 2009 08:05:00 -0400 Received: from mx2.redhat.com ([66.187.237.31]:32951) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MNQSo-0002Lo-ES for qemu-devel@nongnu.org; Sun, 05 Jul 2009 08:04:59 -0400 Message-ID: <4A50976A.8040901@redhat.com> Date: Sun, 05 Jul 2009 15:07:06 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20090705114057.GE4798@redhat.com> <20090705115601.GA4826@redhat.com> In-Reply-To: <20090705115601.GA4826@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: kwolf@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, glommer@redhat.com, qemu-devel@nongnu.org, Blue Swirl On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote: >> With the braces comment I meant that while working on the code, you >> should update it to match CODING_STYLE: >> if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) { >> return; >> } >> > > Yea ... it's probably better to do this all over the file, not piecewise, > though. No? > No, that just causes churn (and merge conflicts for me). Better to only fix if you have a patch that modifies the same place. -- error compiling committee.c: too many arguments to function