From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNZYw-0006Vd-Em
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 17:47:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNZYr-0006NE-Uf
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 17:47:54 -0400
Received: from [199.232.76.173] (port=58334 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNZYr-0006Mt-RE
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 17:47:49 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:39062)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MNZYr-0001Y9-GU
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 17:47:49 -0400
Message-ID: <4A511F7B.6040504@web.de>
Date: Sun, 05 Jul 2009 23:47:39 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <200906300055.n5U0tAD8013302@d03av01.boulder.ibm.com>
	<4A4F3967.9040106@web.de>
In-Reply-To: <4A4F3967.9040106@web.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigBEC4C5EA664A05261D4F282A"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [COMMIT 707c0db] support colon in filenames
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: linuxram@us.ibm.com, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigBEC4C5EA664A05261D4F282A
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Jan Kiszka wrote:
> Anthony,
>=20
> please revert this patch until Ram Pai provides a better version. It
> causes too many problems. At least it
>=20
>  - breaks -pflash somefile -snapshot

Some more details on this: it's not just pflash that suffers, -snapshot
was broken for raw images in general. Declaring file access as a
protocol apparently has some unwanted side effects that first have to be
resolved (check also bdrv_open2 /wrt realpath).

>  - breaks mingw32 build due to redefined _open

Sorry, this obviously does not apply to the merged revision 2 but to
rev3 which I had applied locally.

>  - uses PATH_MAX
>=20
> rev3 does not fix any of the above.
>=20
> At this chance: there is at least one indention issue remaining in
> fill_token() which would be nice to fix while reworking the patch.
>=20
> Jan
>=20

Jan


--------------enigBEC4C5EA664A05261D4F282A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkpRH4AACgkQniDOoMHTA+nyxgCfSroljz7s3BYBKp3rKZ4YaK2x
MVQAnRcjMMDya40uZT/W8m4jeqVfGQLs
=dUt5
-----END PGP SIGNATURE-----

--------------enigBEC4C5EA664A05261D4F282A--