qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 0/4] Machine config files
Date: Mon, 06 Jul 2009 16:40:06 +0200	[thread overview]
Message-ID: <4A520CC6.7060802@redhat.com> (raw)
In-Reply-To: <20090706140129.GB12141@redhat.com>

On 07/06/09 16:01, Michael S. Tsirkin wrote:
>>> Current savevm
>>> doesn't do that, thats why you have to start the virtual machine with
>>> the complete set of command line arguments even when resuming /
>>> migrating.
>
> It seems that it'd be trivial to solve this just by adding a fixed size header
> telling you which load function to call. No?

No.  Go read the code.

User adds -somedev params,more=options to the command line.  Qemu asks 
the corresponding driver to creates a device instance.  Every device 
instance registers loadvm/savevm callbacks to load/save state (tagged 
with name + instance id).

When loading vm state qemu will see name + instance id.  There is no way 
to figure the actual driver from that.

Additionall issue: There is no standardized way to create a device 
instance.  This one will be fixed by qdev though.

It might make sense to integrate savevm callbacks into qdev, then you'd 
have actually a chance to figure which driver belongs to your piece of 
savevm state.  I suspect it isn't enougth to make it work though, you 
still need to know the position of the device in the device tree.  To 
answer questions like "is your pci device behind a bridge and if so 
which one?".

cheers,
   Gerd

  reply	other threads:[~2009-07-06 14:40 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 17:38 [Qemu-devel] [PATCH 0/4] Machine config files Paul Brook
2009-06-10 17:38 ` [Qemu-devel] [PATCH 1/4] Include and build libfdt Paul Brook
2009-06-10 19:08   ` Glauber Costa
2009-06-10 19:23     ` Anthony Liguori
2009-06-10 19:27     ` Paul Brook
2009-06-10 19:41       ` Glauber Costa
2009-06-10 20:38         ` Paul Brook
2009-06-10 22:32       ` Edgar E. Iglesias
2009-06-10 19:34     ` Blue Swirl
2009-06-10 17:38 ` [Qemu-devel] [PATCH 2/4] Add device tree machine Paul Brook
2009-06-10 18:30   ` Blue Swirl
2009-06-10 19:10     ` Paul Brook
2009-06-11 13:22   ` Gerd Hoffmann
2009-06-11 13:33   ` Gerd Hoffmann
2009-06-11 13:39     ` Paul Brook
2009-06-11 14:22       ` Gerd Hoffmann
2009-06-12 16:25   ` Markus Armbruster
2009-06-10 17:38 ` [Qemu-devel] [PATCH 3/4] Stellaris machine config Paul Brook
2009-06-11  8:21   ` M P
2009-06-11 16:32     ` Jamie Lokier
2009-06-12  8:29       ` Gerd Hoffmann
2009-06-12 13:56         ` Markus Armbruster
2009-06-12 13:53       ` Markus Armbruster
2009-06-12 15:25         ` Jamie Lokier
2009-06-10 17:38 ` [Qemu-devel] [PATCH 4/4] Integrator " Paul Brook
2009-06-11  9:54 ` [Qemu-devel] [PATCH 0/4] Machine config files Gerd Hoffmann
2009-06-11 12:53 ` Gerd Hoffmann
2009-06-11 13:18   ` Paul Brook
2009-06-11 14:35     ` Gerd Hoffmann
2009-06-12  7:51     ` Kevin Wolf
2009-06-12 13:49       ` Markus Armbruster
2009-06-12 14:22         ` Kevin Wolf
2009-06-12 14:40           ` Markus Armbruster
2009-06-12 15:02           ` Anthony Liguori
2009-06-12 15:29             ` Kevin Wolf
2009-06-12 16:35             ` Blue Swirl
2009-06-12 13:37 ` Markus Armbruster
2009-06-12 14:44   ` Gerd Hoffmann
2009-06-12 15:58     ` Markus Armbruster
2009-06-12 16:11     ` [Qemu-devel] " Jan Kiszka
2009-07-06 12:49       ` Michael S. Tsirkin
2009-07-06 13:43         ` Gerd Hoffmann
2009-07-06 13:56           ` Michael S. Tsirkin
2009-07-06 14:01             ` Michael S. Tsirkin
2009-07-06 14:40               ` Gerd Hoffmann [this message]
2009-07-06 16:12                 ` Avi Kivity
2009-07-06 16:27                   ` Gerd Hoffmann
2009-07-06 16:37                     ` Avi Kivity
2009-07-06 16:44                       ` Michael S. Tsirkin
2009-07-07  4:47                         ` Avi Kivity
2009-07-06 16:47                       ` Paul Brook
2009-07-07  5:01                         ` Avi Kivity
2009-07-06 17:28                       ` Anthony Liguori
2009-07-06 22:39                         ` Paul Brook
2009-07-06 23:13                           ` Anthony Liguori
2009-07-07  5:00                             ` Avi Kivity
2009-07-07  5:23                             ` Avi Kivity
2009-07-07  4:56                         ` Avi Kivity
2009-07-07  6:19                         ` Michael S. Tsirkin
2009-07-06 14:24             ` Gerd Hoffmann
2009-07-06 14:31               ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A520CC6.7060802@redhat.com \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).