From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNqlt-0002HN-V0 for qemu-devel@nongnu.org; Mon, 06 Jul 2009 12:10:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNqlo-0002DJ-To for qemu-devel@nongnu.org; Mon, 06 Jul 2009 12:10:25 -0400 Received: from [199.232.76.173] (port=41851 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNqlo-0002Ct-Jz for qemu-devel@nongnu.org; Mon, 06 Jul 2009 12:10:20 -0400 Received: from mx2.redhat.com ([66.187.237.31]:45923) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MNqlm-0004tN-5l for qemu-devel@nongnu.org; Mon, 06 Jul 2009 12:10:20 -0400 Message-ID: <4A52226C.8060606@redhat.com> Date: Mon, 06 Jul 2009 19:12:28 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 0/4] Machine config files References: <20090610173803.4674.82538.stgit@wren.home> <878wjx374h.fsf@pike.pond.sub.org> <4A3269C3.3050307@redhat.com> <4A327E2C.1060207@siemens.com> <20090706124928.GB11998@redhat.com> <4A51FF7B.4000602@redhat.com> <20090706135616.GA12141@redhat.com> <20090706140129.GB12141@redhat.com> <4A520CC6.7060802@redhat.com> In-Reply-To: <4A520CC6.7060802@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Jan Kiszka , Markus Armbruster , "Michael S. Tsirkin" On 07/06/2009 05:40 PM, Gerd Hoffmann wrote: > It might make sense to integrate savevm callbacks into qdev, then > you'd have actually a chance to figure which driver belongs to your > piece of savevm state. That's my preference. The very first pass iterates the device tree and serializes it. > I suspect it isn't enougth to make it work though, you still need to > know the position of the device in the device tree. To answer > questions like "is your pci device behind a bridge and if so which one?". Isn't that info provided by qdev? qdev will walk the pci bus, note there's a bridge, walk the bridged pci bus, note there's a usb controller, walk the usb bus, note there's a usb-scsi controller, walk the scsi bus, ... (ran out of steam). -- error compiling committee.c: too many arguments to function