From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNrqs-0000ht-H0
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 13:19:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNrqn-0000hR-OJ
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 13:19:38 -0400
Received: from [199.232.76.173] (port=35423 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNrqn-0000hO-JT
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 13:19:33 -0400
Received: from moutng.kundenserver.de ([212.227.17.9]:64592)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1MNrqn-0005Wa-2b
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 13:19:33 -0400
Message-ID: <4A523220.8030204@mail.berlios.de>
Date: Mon, 06 Jul 2009 19:19:28 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add new block driver for the VDI format
References: <4A4E5AFC.4020206@mail.berlios.de>
	<1246649386-6006-1-git-send-email-weil@mail.berlios.de>
	<1246649386-6006-2-git-send-email-weil@mail.berlios.de>
	<20090705080523.GA31550@lst.de> <4A50B275.7030100@mail.berlios.de>
	<20090706102500.GB7835@lst.de>
In-Reply-To: <20090706102500.GB7835@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Christoph Hellwig schrieb:
> On Sun, Jul 05, 2009 at 04:02:29PM +0200, Stefan Weil wrote:
>   
>> CONFIG_VDI_UNSUPPORTED and CONFIG_VDI_SNAPSHOT document
>> code parts which are still missing or unfinished.
>> For the same reason, they are undefined, so the unfinished
>> code is deactivated.
>>     
>
>   
>> Not having the method would hide the fact that the
>> method might be implemented.
>>
>> vdi_check is unfinished code, and there is even a comment
>> which says that there remains something to do.
>>     
>
> Keeping stubs around as a reminder is very bad coding practice.  You
> already have a todo list reminding about the missing features on the
> top of the file.  Note that the feature set of your vdi driver is the
> same as all the other non-native image format drivers, so it's not
> really anything special anyway.
>   

My opinion about bad coding practices differs from yours.

Why do you think that stubs are even a very bad coding practice?

The potential feature set of the vdi driver is more than that of the
other non-native image format drivers. It is nearer to that of qcow2.

>   
>> By the way - is it possible to check new block drivers like this one
>> using qemu-io (can I use an existing test sequence)?
>>     
>
> I've put support into qemu-iotests to run with the vdi format.  It
> passes all test that currently are available for vdi.
>
>   

Thanks for this feedback. There are still errors in my first driver release
(endianess, block allocation) which will be fixed in the next release.

Regards,

Stefan