From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Test L1 table growth
Date: Tue, 07 Jul 2009 09:40:17 +0200 [thread overview]
Message-ID: <4A52FBE1.70302@redhat.com> (raw)
In-Reply-To: <20090706185448.GA6800@lst.de>
Christoph Hellwig schrieb:
> On Mon, Jul 06, 2009 at 03:59:27PM +0200, Kevin Wolf wrote:
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>> I don't really like about this one that it contains the monitor echo of our
>> commands from stdin. It contains lots of control characters and who knows if
>> the monitor won't change to do a more reasonable echo some time... However, we
>> need the monitor output to see if an error occured during savevm or loadvm. So,
>> I'm open for suggestions, but in case nobody has a better option, let's do it
>> this way.
>
> It does fail for me because I get different escape sequences..
>
> I suspect we'll just have to wait until Luiz' gets a proper
> machine-readable protocol for the monitor in and then use that one. And
> pray that we'll stick with the text protocol instead of some rpc
> crap..
Ok, so using qemu in our tests is basically impossible because we can't
get any status messages. Bad news.
For this one we can handle it differently: I'll implement
bdrv_get/put_buffer in qemu-io, this should be more or less the same to
the image format drivers. We even get more control over the data
written, so I guess this is the better approach anyway.
Kevin
next prev parent reply other threads:[~2009-07-07 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 13:59 [Qemu-devel] [PATCH] qemu-iotests: Test L1 table growth Kevin Wolf
2009-07-06 18:54 ` Christoph Hellwig
2009-07-07 7:40 ` Kevin Wolf [this message]
2009-07-07 10:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A52FBE1.70302@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).