From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MO5Rp-0002wk-EI for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:50:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MO5Rl-0002vU-0I for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:50:41 -0400 Received: from [199.232.76.173] (port=42019 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MO5Rk-0002vR-Qn for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:50:36 -0400 Received: from mx20.gnu.org ([199.232.41.8]:55402) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MO5Rk-0004TI-Aa for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:50:36 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MO5Rj-0006mi-Iw for qemu-devel@nongnu.org; Tue, 07 Jul 2009 03:50:35 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n677oXwG002351 for ; Tue, 7 Jul 2009 03:50:33 -0400 Message-ID: <4A52FED7.4090800@redhat.com> Date: Tue, 07 Jul 2009 10:52:55 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors References: <1246901401.12086.20.camel@blaa> <4A52DD05.9030007@redhat.com> <1246952623.2836.13.camel@blaa> In-Reply-To: <1246952623.2836.13.camel@blaa> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: qemu-devel On 07/07/2009 10:43 AM, Mark McLoughlin wrote: > >> (qemu) getfd foo >> (qemu) getfd bar >> (qemu) getfd baz >> (qemu) pci_add ...,fd=foo >> (qemu) pci_add ...,fd=bar ...,fd=baz >> >> A closefd command would be needed to deal with errors. >> > > Nice idea, certainly. > > However, since it's only currently useful for tap/socket networking, I'm > happier with not adding two new monitor commands and only supporting a > single fd for now. > What happens when we do get more commands? Do we then add the new commands and special-case fd=msgfd ? -- error compiling committee.c: too many arguments to function